Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set out on the root command #2445

Merged
merged 1 commit into from Jul 10, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 10, 2019

Signed-off-by: David Gageot david@gageot.net

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #2445 into master will decrease coverage by <.01%.
The diff coverage is 98.18%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/deploy.go 64.28% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/config.go 100% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/debug.go 50% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/dev.go 23.07% <100%> (-1.93%) ⬇️
cmd/skaffold/app/cmd/fix.go 67.74% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/diagnose.go 35% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/completion.go 12.5% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/find_configs.go 39.58% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/version.go 75% <100%> (ø) ⬆️
cmd/skaffold/app/cmd/commands.go 100% <100%> (ø) ⬆️
... and 5 more

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@dgageot dgageot merged commit d27045c into GoogleContainerTools:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants