Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass extra env to the Docker CLI #2737

Merged
merged 2 commits into from Aug 28, 2019
Merged

Pass extra env to the Docker CLI #2737

merged 2 commits into from Aug 28, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 28, 2019

Fix #1749

Signed-off-by: David Gageot david@gageot.net

balopat
balopat suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think one more testcase could be helpful

@codecov
Copy link

codecov bot commented Aug 28, 2019 •
edited

Codecov Report

Merging #2737 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/build/local/docker.go 87.5% <100%> (+34.3%) ⬆️
pkg/skaffold/docker/auth.go 72.09% <0%> (+9.3%) ⬆️

@dgageot dgageot force-pushed the fix-1749 branch 2 times, most recently from 17857d8 to 11548f5 Compare August 28, 2019 17:14
@dgageot
Copy link
Contributor Author

dgageot commented Aug 28, 2019

@balopat should be good now

@dgageot
Pass extra env to the Docker CLI
7f3ae85 
Fix GoogleContainerTools#1749

Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Add a test with collisions
897f34f 
Signed-off-by: David Gageot <david@gageot.net>
@balopat balopat merged commit fdfbc5c into GoogleContainerTools:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skaffold crashes when building Docker image using Minikube Docker daemon with buildkit
3 participants
@dgageot @balopat @googlebot