Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Git parent directory #275

Merged
merged 1 commit into from Mar 23, 2018
Merged

Detect Git parent directory #275

merged 1 commit into from Mar 23, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 23, 2018

Fixes #274

Signed-off-by: David Gageot david@gageot.net

@dgageot
Detect Git parent directory
6210740 
Fixes GoogleContainerTools#274

Signed-off-by: David Gageot <david@gageot.net>
@r2d4
Copy link
Contributor

r2d4 commented Mar 23, 2018 

findtopLevelGitDir
55.453µs

PlainOpen
729.602µs

Worktree
382ns

Status
2.480806782s

Head
388.1µs

IsClean
18.062µs
...

Was a bit slow on getting the status, but we can track that somewhere else since this fixes the bug.

@r2d4 r2d4 merged commit 21d2aee into GoogleContainerTools:master Mar 23, 2018
@dgageot dgageot deleted the detect-git-parent branch May 9, 2018 05:29
@StevenACoffman StevenACoffman mentioned this pull request May 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgageot @r2d4