Ignore Jib project name when skaffold init only finds one module #2850
Conversation
TadCordle
requested review from
balopat,
briandealwis,
chanseokoh,
dgageot,
loosebazooka,
nkubala,
priyawadhwa and
tejal29
as code owners
| @@ -156,7 +156,11 @@ func ValidateJibConfig(path string) []Jib { | |||
| return nil | |||
| } | |||
|
|
|||
| results[i] = Jib{BuilderName: builderType.Name(), Image: parsedJSON.Image, FilePath: path, Project: parsedJSON.Project} | |||
| results[i] = Jib{BuilderName: builderType.Name(), Image: parsedJSON.Image, FilePath: path} | |||
There was a problem hiding this comment.
What happens if a multi-module project has only one sub-module? That is, a root pom.xml (<packaging>pom) and a single sub-directory for one module. Does jib:skaffold-init return one BEGIN JIB JSON?
There was a problem hiding this comment.
I can double check, but I think it returns one for the root project and one for the module.
There was a problem hiding this comment.
Can confirm it does this, but that also may not be a good thing in the first place to count the root project in a multi-module situation as a valid project to choose from in skaffold init... hmm
There was a problem hiding this comment.
I'm beginning to think this is best fixed Jib-side. I'm going to mess around with Jib and see if I can get somewhere close, and if so then I'll close this.
Codecov Report
|
1 similar comment
Codecov Report
|
Fixes #2844
@GoogleContainerTools/java-tools-build