Stream logs from deployed containers #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
changed the title
r2d4
changed the title
|
@dlorenc this should be ready for a look too |
dlorenc
reviewed
Feb 15, 2018
pkg/skaffold/kubernetes/log.go
Outdated
| return errors.Wrap(err, "writing to out") | ||
| } | ||
| } | ||
| msg := fmt.Sprintf("%s Stream finished", header) |
| return errors.Wrap(err, "getting pods") | ||
| } | ||
| logrus.Infof("Looking for logs to stream for %s", image) | ||
| for _, p := range pods.Items { |
There was a problem hiding this comment.
Can we put these into the Pods("") query instead of doing the selection here?
There was a problem hiding this comment.
I don't think that field selectors support anything nested like container image fields. I couldn't find any examples of this
|
this should be ready for another look |
Interfacer throws a warning on passing a PodInterface as a corev1.CoreV1Interface but the client-go code restricts us from doing so.
dlorenc
approved these changes
Mar 2, 2018
| if bRes != nil { | ||
| for _, b := range bRes.Builds { | ||
| tag := b.Tag | ||
| go kubernetes.StreamLogsRetry(r.out, r.kubeclient.CoreV1(), tag, 5) |
There was a problem hiding this comment.
Do we need to pass in a cancel channel?
There was a problem hiding this comment.
It will exit when the container exists on the cluster, so you'll receive messages up until then, which is kind of a feature 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #28
Fixes #26