Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs updates #3079

Merged
merged 2 commits into from Oct 17, 2019
Merged

Docs updates #3079

merged 2 commits into from Oct 17, 2019

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Oct 17, 2019

No description provided.

@balopat balopat added the docs-modifications runs the docs preview service on the given PR label Oct 17, 2019
@container-tools-bot
Copy link

Please visit http://35.236.38.41:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications runs the docs preview service on the given PR label Oct 17, 2019
balopat
balopat approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple of nits! Thank you!

@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited

Codecov Report

Merging #3079 into master will not change coverage.
The diff coverage is 35.29%.

Impacted Files Coverage Δ
pkg/skaffold/util/util.go 86.48% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/flags.go 100% <ø> (ø) ⬆️
pkg/skaffold/initializer/init.go 57.45% <ø> (ø) ⬆️
pkg/skaffold/docker/client.go 73.73% <ø> (ø) ⬆️
pkg/skaffold/kubernetes/client.go 40% <0%> (ø) ⬆️
pkg/skaffold/debug/debug.go 43.33% <0%> (ø) ⬆️
pkg/skaffold/deploy/status_check.go 53.77% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/sources/localdir.go 43.47% <0%> (ø) ⬆️
...ffold/kubernetes/portforward/resource_forwarder.go 88% <0%> (ø) ⬆️
pkg/skaffold/build/cluster/secret.go 36.2% <0%> (ø) ⬆️
... and 7 more

@nkubala nkubala merged commit 1f2f338 into GoogleContainerTools:master Oct 17, 2019
@nkubala nkubala deleted the docs-updates branch October 17, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

@briandealwis briandealwis Awaiting requested review from briandealwis

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nkubala @container-tools-bot @balopat @googlebot