Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars to kaniko specs #3115

Closed
wants to merge 3 commits into from
Closed

Add env vars to kaniko specs #3115

wants to merge 3 commits into from

Conversation

cyrildiagne
Copy link
Contributor

Relates to #731

Fixes #731.

Description

This will give users the option to provide environment variables to the kaniko pod.
This should fix #731 and enable ECR support on regions other than the default one.

User facing changes

n/a

Next PRs.

n/a

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

Release Notes

Add buildArgs to `Kustomize` deployer skaffold config.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #3115 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100% <ø> (ø) ⬆️
pkg/skaffold/build/cluster/sources/sources.go 91.89% <100%> (+0.3%) ⬆️

@cyrildiagne
Copy link
Contributor Author

Do I need to do something for the Kokoro check to pass? I understood from the doc that it would be launched when a project owner tags the PR.

@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Oct 31, 2019
@dgageot
Copy link
Contributor

dgageot commented Oct 31, 2019

Sorry @cyrildiagne, this needs a rebase. We've introduced schema version v1beta18

@cyrildiagne
Copy link
Contributor Author

Ok sorry for the delay.
I'm closing this and will do another PR with the latest schema version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold/Kaniko with ECR
4 participants