Empty, non-nil `sync` = sync all the files and infer destination #3496

dgageot · 2020-01-10T13:58:27Z

Signed-off-by: David Gageot david@gageot.net

codecov · 2020-01-10T14:07:28Z

Codecov Report

Merging #3496 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
pkg/skaffold/schema/latest/config.go	`100% <ø> (ø)`	⬆️
pkg/skaffold/schema/defaults/defaults.go	`94.38% <100%> (+0.12%)`	⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go	`68.29% <0%> (+2.43%)`	⬆️

Signed-off-by: David Gageot <david@gageot.net>

nkubala

LGTM

dgageot requested review from balopat, nkubala and tejal29 as code owners January 10, 2020 13:58

googlebot added the cla: yes label Jan 10, 2020

pull-request-size bot added the size/M label Jan 10, 2020

briandealwis approved these changes Jan 14, 2020

View reviewed changes

briandealwis mentioned this pull request Jan 14, 2020

Demonstrate inferred sync #3495

Merged

dgageot force-pushed the auto-sync-v2 branch from 68043c3 to 32a5d5c Compare January 14, 2020 21:33

tejal29 assigned nkubala Jan 14, 2020

dgageot force-pushed the auto-sync-v2 branch 5 times, most recently from 301eaf8 to badeb8f Compare January 20, 2020 07:23

Empty, non-nil sync = sync all the files and infer destination

2067995

Signed-off-by: David Gageot <david@gageot.net>

dgageot force-pushed the auto-sync-v2 branch from badeb8f to 2067995 Compare January 20, 2020 13:59

nkubala approved these changes Jan 21, 2020

View reviewed changes

nkubala merged commit 5ee3f91 into GoogleContainerTools:master Jan 21, 2020