Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[init refactor] cleanup on analyzers and moving things into a single package #3538

Merged

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jan 20, 2020

No functional change, pure refactor.

  • moved kubectl package back into initializer - everything is unexported - we really don't need exporting there
  • moved analyzers to their corresponding files - this way logic stay closer to each other - we can already see much easier how the kubectlnitializer gets the manifests - there are more simplifications to come there!

@balopat balopat force-pushed the init_refactor/cleanup_analyzers branch from 31e51be to cc9a7f1 Compare January 20, 2020 16:18
@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3538 into master will increase coverage by 0.03%.
The diff coverage is 88.23%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/init.go 0% <0%> (ø) ⬆️
pkg/skaffold/initializer/config.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/util.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/builders.go 93.44% <100%> (+0.58%) ⬆️
pkg/skaffold/initializer/analyze.go 82.35% <60%> (-6.74%) ⬇️
pkg/skaffold/initializer/kubectl.go 87.34% <87.5%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

@dgageot dgageot merged commit 8d56bcb into GoogleContainerTools:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants