Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli tools #3553

Merged
merged 2 commits into from Jan 27, 2020
Merged

Update cli tools #3553

merged 2 commits into from Jan 27, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jan 22, 2020

This is a follow up of #3527

nicknovitski and others added 2 commits January 22, 2020 07:11
@nicknovitski @dgageot
Update CLI tools in docker image
9310225 
Helm purposely not updated due to breaking integration tests.

kubectl purposely only updated two major versions, to retain compatibility with
more clusters.
@dgageot
Update Dockerfile
917609f 
Signed-off-by: David Gageot <david@gageot.net>
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@dgageot dgageot mentioned this pull request Jan 22, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited

Codecov Report

Merging #3553 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@dgageot
Copy link
Contributor Author

dgageot commented Jan 22, 2020

@nicknovitski can you give your consent that I use your commit?

@balopat balopat self-assigned this Jan 22, 2020
@dgageot
Copy link
Contributor Author

dgageot commented Jan 23, 2020

ping @nicknovitski

@nicknovitski
Copy link
Contributor

Ah, here it is. Yeah, I consent to having my commit used in this PR. Thanks!

@balopat balopat added cla: yes and removed cla: no labels Jan 27, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@balopat balopat merged commit 2c048c2 into GoogleContainerTools:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees

@balopat balopat

Labels
cla: yes pr/lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgageot @googlebot @nicknovitski @balopat