Add unit test for findRunImage
#3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Codecov Report
|
dgageot
force-pushed
the
test-find-image
branch
from
37f4fb2
to
924ce93
Compare
balopat
reviewed
Jan 22, 2020
| if err != nil { | ||
| return "", err | ||
| return "", errors.Wrapf(err, "unable find image %q", a.Builder) |
There was a problem hiding this comment.
nit:
Suggested change
| return "", errors.Wrapf(err, "unable find image %q", a.Builder) | |
| return "", errors.Wrapf(err, "unable to find image %q", a.Builder) |
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
test-find-image
branch
from
924ce93
to
70c8053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.