Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include unrecognized builder in error #3595

Merged

Conversation

jonjohnsonjr
Copy link
Contributor

Description

Improve the skaffold init --artifact error mesage for unrecognized builders.

User facing changes

Different error message.

Before

$ skaffold init --artifact '{"builder": "404"}'
FATA[0001] processing cli artifacts: unknown builder type in CLI artifacts 

After

$ skaffold init --artifact '{"builder": "404"}'
FATA[0001] processing cli artifacts: unknown builder type in CLI artifacts: "404" 

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Mentions any output changes.
  • Adds documentation as needed: user docs, YAML reference, CLI reference.
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit test added.
  • User facing changes look good.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #3595 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/builders.go 94.2% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@balopat balopat merged commit 974741c into GoogleContainerTools:master Jan 28, 2020
@jonjohnsonjr jonjohnsonjr deleted the better-builder-error branch February 4, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants