Disable all colors in Buildpacks’s output when not in a terminal #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgageot
commented
Feb 6, 2020
dgageot
commented
- Make sure the output from pack and from buildpacks goes to stdout
- Make sure all colors are disabled when not printing to a terminal
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
|
briandealwis
approved these changes
Feb 6, 2020
|
|
||
| l := logrus.New() | ||
| l.SetOutput(out) | ||
| l.SetFormatter(new(plainFormatter)) |
There was a problem hiding this comment.
I'd appreciate a comment here as to why this formatter is required
| // If out is not a terminal, let's make sure pack doesn't output with colors. | ||
| if _, isTerm := util.IsTerminal(out); !isTerm { | ||
| // pack uses heroku/color under the hood. | ||
| color.Disable(true) |
There was a problem hiding this comment.
Oh, I guess a problem here is that we never re-enable color.
There was a problem hiding this comment.
Yes, the new code is more robust
balopat
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.