[refactor] make DoInit() a proper controller #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
added
refactor
balopat
reviewed
Feb 12, 2020
| // deploymentInitializer detects a deployment type and is able to extract image names from it | ||
| type DeploymentInitializer interface { | ||
| // Initializer detects a deployment type and is able to extract image names from it | ||
| type Initializer interface { |
There was a problem hiding this comment.
Why? I think this is focused on Deployments.
There was a problem hiding this comment.
it reads a little clearer now, since we're using build.Initializer and deploy.Initializer in the same code block
balopat
approved these changes
Feb 12, 2020
balopat
reviewed
Feb 12, 2020
balopat
reviewed
Feb 12, 2020
Codecov Report
|
nkubala
force-pushed
the
init-refactor-controller
branch
from
f3632e8
to
e9e572a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last piece of the init refactor. this transfer control of the individual pieces of the init flow to their respective components, and refactors the
DoInit()entrypoint to simply control these components without worrying about their implementations.this PR has no functional change.