Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip large files during skaffold init #3717

Merged
merged 2 commits into from
Feb 22, 2020
Merged

skip large files during skaffold init #3717

merged 2 commits into from
Feb 22, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Feb 21, 2020

Fixes #3619.

@balopat balopat mentioned this pull request Feb 21, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #3717 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted Files Coverage Δ
pkg/skaffold/initializer/analyze/kubernetes.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 100% <100%> (ø) ⬆️
pkg/skaffold/initializer/analyze/analyze.go 89.09% <71.42%> (-2.58%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

nkubala
nkubala approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit: should we document somewhere that 500MB is the max file size for skaffold init?

@balopat
Copy link
Contributor Author

balopat commented Feb 21, 2020

restarted kokoro - it flaked: #3719

@balopat balopat merged commit 4c9d801 into GoogleContainerTools:master Feb 22, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skaffold init - loads all files to memory
3 participants
@balopat @nkubala @googlebot