New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kustomize dependencies include environment files (#3720) #3721
Merged
balopat
merged 1 commit into
GoogleContainerTools:master
from
nicknovitski:kustomize-watch-env-files
Apr 2, 2020
Merged
kustomize dependencies include environment files (#3720) #3721
balopat
merged 1 commit into
GoogleContainerTools:master
from
nicknovitski:kustomize-watch-env-files
Apr 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicknovitski
requested review from
balopat,
dgageot,
nkubala and
tejal29
as code owners
February 22, 2020 01:38
nicknovitski
force-pushed
the
kustomize-watch-env-files
branch
from
February 22, 2020 02:07
2dd54d6
to
6a390d2
Compare
If I remember right, a maintainer has to approve the running of the kokoro tests. |
tejal29
requested changes
Feb 28, 2020
Codecov Report
|
Thank you for your PR! This looks really great, except for some nits. If you append Thank you! looking forward to get this in! |
nicknovitski
force-pushed
the
kustomize-watch-env-files
branch
from
March 2, 2020 07:06
6a390d2
to
c87abfd
Compare
Thanks for your suggestions, I've added them. |
tejal29
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3720.
Description
ConfigMapGenerators and SecretGenerators can have
env
orenvs
fields, with paths to "environment files", with a format like this:Each line in the file creates a new key-value pair in the generated ConfigMap or Secret. Thus, changes to the contents of those files should trigger redeploys.
User facing changes
Before
While running skaffold dev or debug, changes to the environment files would not trigger a redeploy.
After
They do.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes