Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use heroku/color for our colors #3757

Merged
merged 2 commits into from Feb 29, 2020
Merged

Use heroku/color for our colors #3757

merged 2 commits into from Feb 29, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Feb 28, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Feb 28, 2020 •
edited

Codecov Report

Merging #3757 into master will decrease coverage by 0.05%.
The diff coverage is 90.9%.

Impacted Files Coverage Δ
pkg/skaffold/build/parallel.go 93.93% <100%> (-0.43%) ⬇️
cmd/skaffold/app/cmd/cmd.go 68.46% <100%> (+1.03%) ⬆️
pkg/skaffold/color/formatter.go 90% <90%> (-10%) ⬇️
pkg/skaffold/util/term.go 50% <0%> (-50%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@dgageot
Use heroku/color for our colors
0295d87 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot
Fix imports
ebd88c8 
Signed-off-by: David Gageot <david@gageot.net>
tejal29
tejal29 reviewed Feb 28, 2020
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to run go mod vendor ? I dont see any files added for the new dependency

@tejal29 tejal29 self-assigned this Feb 28, 2020
@dgageot
Copy link
Contributor Author

dgageot commented Feb 28, 2020

@tejal29 It was already vendored for pack

@dgageot dgageot merged commit a9c7b3a into GoogleContainerTools:master Feb 29, 2020
@fmotrifork fmotrifork mentioned this pull request Mar 11, 2020
Merged
@briandealwis briandealwis mentioned this pull request Sep 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

Assignees

@tejal29 tejal29

Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgageot @tejal29 @googlebot