Normalize capitalization for types while port forwarding #3803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if
--port-forward
is used, skaffold will create automated port forwards for resources that are not defined in theportForward
field. This works great, but sometimes there are issues with capitalization. For example, I was recently working on a project where the type of the service resource was understood to beservice
by skaffold, but in theportForward
section of theskaffold.yaml
, I had set the Type toService
. These were interpreted as two different port forwarding configurations and leads to unintentional duplication on the same resource.My solution to this was to normalize the capitalization when calculating the
key
for theportForwardEntry
. This makes it such that resources of the same type, but different capitalization, will be treated the same. Ex.service/my-api-service
andService/my-api-service
will be treated the same.A unit test has been added to support this.