Fix this integration test on minikube #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaffold will build the image in the minikube’s Docker engine. The integration used to search the image into the default Docker engine. Signed-off-by: David Gageot <david@gageot.net>
Codecov Report
|
nkubala
reviewed
Mar 16, 2020
| cfg, err := kubectx.CurrentConfig() | ||
| failNowIfError(t, err) | ||
|
|
||
| // TODO: use the proper RunContext |
There was a problem hiding this comment.
why can't we just use runcontext.GetRunContext() here?
There was a problem hiding this comment.
We don't really have SkaffoldOptions and SkaffoldPipeline available.
nkubala
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skaffold will build the image in the minikube’s Docker engine. The integration used to search the image into the default Docker engine.
Signed-off-by: David Gageot david@gageot.net