Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format go test output with Go rather than bash and jq #3853

Merged
merged 1 commit into from Mar 22, 2020
Merged

Format go test output with Go rather than bash and jq #3853

merged 1 commit into from Mar 22, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 20, 2020

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Mar 20, 2020 •
edited

Codecov Report

Merging #3853 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@dgageot
Format go test output with Go rather than bash and jq
55900a5 
Signed-off-by: David Gageot <david@gageot.net>
balopat
balopat approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it

@balopat balopat merged commit 08680df into GoogleContainerTools:master Mar 22, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgageot @balopat @googlebot