Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go test helper #3859

Merged
merged 1 commit into from Mar 23, 2020
Merged

Fix go test helper #3859

merged 1 commit into from Mar 23, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 23, 2020

Sometimes, go test -json outputs plain text instead of json.
For example in case of a build error.

Signed-off-by: David Gageot david@gageot.net

@dgageot
Fix go test helper
e47ca3b 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited

Codecov Report

Merging #3859 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0%> (-2.44%) ⬇️

@nkubala nkubala merged commit 86b290e into GoogleContainerTools:master Mar 23, 2020
@fmotrifork fmotrifork mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgageot @nkubala @googlebot