Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kustomize example with an image built by skaffold #3901

Merged
merged 2 commits into from Apr 6, 2020

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Apr 1, 2020

this just adds a quick example of using skaffold with kustomize on an image being built in the same project.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #3901 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/deploy/resource/deployment.go 90.9% <0%> (-3.69%) ⬇️
pkg/skaffold/deploy/status_check.go 68.3% <0%> (-0.76%) ⬇️
pkg/skaffold/initializer/analyze/builder.go 100% <0%> (ø) ⬆️
pkg/skaffold/build/gcb/cloud_build.go 0% <0%> (ø) ⬆️
cmd/skaffold/app/cmd/init.go 100% <0%> (ø) ⬆️
pkg/skaffold/initializer/analyze/analyze.go 89.28% <0%> (+0.19%) ⬆️
pkg/skaffold/runner/deploy.go 67.85% <0%> (+1.19%) ⬆️
pkg/skaffold/deploy/kustomize.go 73.8% <0%> (+1.3%) ⬆️
pkg/skaffold/build/gcb/jib.go 86.36% <0%> (+2.36%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0%> (+2.43%) ⬆️
... and 1 more

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to add an actual test for it too?

@nkubala nkubala added the kokoro:run runs the kokoro jobs on a PR label Apr 3, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 3, 2020
@balopat balopat merged commit f07e7dd into GoogleContainerTools:master Apr 6, 2020
@nkubala nkubala deleted the kustomize-example branch April 6, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants