New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly set namespace when checking for an existing helm release via skaffold deploy #3914
fix: correctly set namespace when checking for an existing helm release via skaffold deploy #3914
Conversation
…se via skaffold deploy
side note: please correct me if I'm wrong, but it looked like a lot of the assertions for the existing unit tests around the helm deploy code were incorrect - most of them were asserting that the I went ahead and fixed these tests and added a few more that used a namespaced skaffold context to assert that the please let me know if I misunderstood something here and if I have to revert it back to the way it was. |
Codecov Report
|
Awesome! Thanks a lot @mrparkers |
Fixes: #3838
Description
When using
skaffold deploy
withhelm
, skaffold was not honoring the--namespace
command-line flag when checking if a helm release already exists. You can reproduce this error using the code within theexamples/helm-deployment
folder:Before this PR:
After this PR: