Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Debug Transformer interface and allow Apply to fail on images #3931

Merged
merged 1 commit into from Apr 14, 2020
Merged

Simplify Debug Transformer interface and allow Apply to fail on images #3931

merged 1 commit into from Apr 14, 2020

Conversation

briandealwis
Copy link
Member

  • avoid panics by returning a ContainerDebugConfiguration instead of a pointer
  • allow returning a different debug-helper image: this will be helpful with support musl vs glibc situations
  • return a more helpful error message when Apply() is unable to be applied

@codecov
Copy link

codecov bot commented Apr 9, 2020 •
edited

Codecov Report

Merging #3931 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/debug/transform.go 89.37% <100.00%> (ø)
pkg/skaffold/debug/transform_go.go 85.86% <100.00%> (-0.31%) ⬇️
pkg/skaffold/debug/transform_jvm.go 94.68% <100.00%> (-0.06%) ⬇️
pkg/skaffold/debug/transform_nodejs.go 77.67% <100.00%> (-0.20%) ⬇️
pkg/skaffold/debug/transform_python.go 84.33% <100.00%> (-0.37%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@briandealwis
Simplify Debug Transformer interface and allow Apply to fail on images
4c26da9 
  - avoid panics by returning a ContainerDebugConfiguration instead of a pointer
  - allow returning a different debug-helper image
  - return a more helpful error message
@dgageot dgageot merged commit 396ccf1 into GoogleContainerTools:master Apr 14, 2020
@briandealwis briandealwis deleted the simplify-apply branch April 18, 2020 18:13
@fmotrifork fmotrifork mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@tejal29 tejal29 Awaiting requested review from tejal29

@balopat balopat Awaiting requested review from balopat

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@nkubala nkubala Awaiting requested review from nkubala

Assignees
No one assigned
Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briandealwis @dgageot @googlebot