Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce v2beta2 #3942

Merged
merged 3 commits into from Apr 14, 2020
Merged

Introduce v2beta2 #3942

merged 3 commits into from Apr 14, 2020

Conversation

briandealwis
Copy link
Member

Merge after: #3941

Description

Create v2beta2 so as to allow specifying artifact runtimes for #2203.

@briandealwis briandealwis mentioned this pull request Apr 11, 2020
Closed
@codecov
Copy link

codecov bot commented Apr 11, 2020 •
edited

Codecov Report

Merging #3942 into master will increase coverage by 0.03%.
The diff coverage is 84.61%.

Impacted Files Coverage Δ
pkg/skaffold/schema/latest/config.go 100.00% <ø> (ø)
pkg/skaffold/schema/v2alpha4/upgrade.go 77.77% <ø> (ø)
pkg/skaffold/schema/versions.go 75.00% <ø> (ø)
pkg/skaffold/schema/v2beta1/upgrade.go 77.77% <77.77%> (ø)
pkg/skaffold/schema/v2beta1/config.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@balopat balopat self-assigned this Apr 13, 2020
@dgageot dgageot added the kokoro:run runs the kokoro jobs on a PR label Apr 14, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Apr 14, 2020
dgageot
dgageot approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@dgageot dgageot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit da5fb49 into GoogleContainerTools:master Apr 14, 2020
@briandealwis briandealwis deleted the v2beta2 branch April 18, 2020 18:13
@fmotrifork fmotrifork mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgageot dgageot dgageot approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@balopat balopat Awaiting requested review from balopat

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

@TadCordle TadCordle Awaiting requested review from TadCordle

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees

@balopat balopat

Labels
cla: yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@briandealwis @dgageot @balopat @googlebot @kokoro-team