Add docs for configuring helm project with skaffold #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
added
the
docs-modifications
|
Please visit http://34.94.185.45:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
tstromberg
approved these changes
Apr 20, 2020
tstromberg
reviewed
Apr 20, 2020
| {{% readfile file="samples/deployers/kustomize.yaml" %}} | ||
|
|
||
| {{< alert title="Note" >}} | ||
| kustomize CLI must be installed on your machine. Skaffold will not |
There was a problem hiding this comment.
Not everyone will know what a CLI is: perhaps: "The kustomize command must be installed"?
Also: maybe this should be moved into a Requirements section before-hand?
"The kustomize command must
There was a problem hiding this comment.
@nkubala Let's merge it. I'll let you fix the nits in a future PR
dgageot
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this provides a little more context on how to set up a helm project with skaffold.