Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceType is of type string #3987

Merged
merged 2 commits into from Apr 20, 2020
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 20, 2020

I searched for a way to solve that without a special case and failed :-)

Fix #3623

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #3987 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

Fix GoogleContainerTools#3623

Signed-off-by: David Gageot <david@gageot.net>
The linter wants us to create a “string” const

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, so in go you can't get aliased types through reflection at runtime....gross 😆

@dgageot dgageot merged commit cf9f2cf into GoogleContainerTools:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is wrong for portForward
3 participants