Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip podspecs that already have a debug.cloud.google.com/config annotation #4027

Merged

Conversation

briandealwis
Copy link
Member

Skip transforming a pod spec if it already has our debug annotation. This ability is useful if someone wants to explicitly configure debugging for a container image such as to customize the dlv command-line used for a Go app.

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #4027 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/debug/transform.go 88.70% <100.00%> (+0.12%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor docs note.

pkg/skaffold/debug/transform.go Show resolved Hide resolved
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests failed to #4044

@dgageot dgageot merged commit 0dcd2c1 into GoogleContainerTools:master Apr 30, 2020
@briandealwis briandealwis deleted the skip-adjusted-podspecs branch May 3, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants