Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast if minikube is used but not started #4042

Merged
merged 2 commits into from Apr 28, 2020
Merged

Fail fast if minikube is used but not started #4042

merged 2 commits into from Apr 28, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Apr 28, 2020

Fixes #4013

@dgageot
Fail fast if minikube is misbehaving
dd5d22b 
Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Apr 28, 2020 •
edited

Codecov Report

Merging #4042 into master will increase coverage by 0.01%.
The diff coverage is 80.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/new.go 70.00% <66.66%> (ø)
cmd/skaffold/app/cmd/runner.go 75.00% <100.00%> (ø)
pkg/skaffold/docker/client.go 72.27% <100.00%> (-0.28%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

@dgageot
Improve the error message
869a167 
Signed-off-by: David Gageot <david@gageot.net>
briandealwis
briandealwis approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice — I just hit this yesterday.

@dgageot dgageot merged commit 43d66c4 into GoogleContainerTools:master Apr 28, 2020
@fmotrifork fmotrifork mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@balopat balopat Awaiting requested review from balopat

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[error scenario] skaffold dev continues with dev loop even though Minikube cluster is not present.
3 participants
@dgageot @briandealwis @googlebot