Buildpacks support Auto sync #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
requested review from
balopat,
briandealwis,
nkubala and
tejal29
as code owners
dgageot
force-pushed
the
buildpacks-auto-sync
branch
from
d9a5bbe
to
f1c1ac8
Compare
Codecov Report
|
briandealwis
approved these changes
Apr 30, 2020
| @@ -219,7 +219,7 @@ func setDefaultSync(a *latest.Artifact) { | |||
| if a.Sync != nil { | |||
| if len(a.Sync.Manual) == 0 && len(a.Sync.Infer) == 0 && a.Sync.Auto == nil { | |||
| switch { | |||
| case a.JibArtifact != nil: | |||
| case a.JibArtifact != nil || a.BuildpackArtifact != nil: | |||
There was a problem hiding this comment.
Do you think we should check that the builder is our builder? Or warn (in case someone builds a builder that includes our devmode buildpacks)?
| @@ -661,7 +661,7 @@ func TestNewSyncItem(t *testing.T) { | |||
| }, | |||
| }, | |||
| evt: filemon.Events{ | |||
| Added: []string{"file.go", "ignored.txt"}, | |||
There was a problem hiding this comment.
The devmode.sync in this example only identifies *.go files, so this shouldn't change with ignored.txt, should it? Oh, I think you just wanted to test this separately.
balopat
added
the
docs-modifications
|
Please visit http://34.94.185.45:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
Signed-off-by: David Gageot <david@gageot.net>
dgageot
force-pushed
the
buildpacks-auto-sync
branch
from
6b8407f
to
0076526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Gageot david@gageot.net