Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only listen to pods for the current RunID #4097

Merged
merged 1 commit into from May 4, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 4, 2020

Fixes #1753

Signed-off-by: David Gageot david@gageot.net

@dgageot
Copy link
Contributor Author

dgageot commented May 4, 2020

This is a reminder that we should fix #3745

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #4097 into master will decrease coverage by 0.04%.
The diff coverage is 56.25%.

Impacted Files Coverage Δ
...skaffold/kubernetes/debugging/container_manager.go 43.28% <0.00%> (-5.05%) ⬇️
pkg/skaffold/runner/debugging.go 30.00% <0.00%> (-3.34%) ⬇️
...affold/kubernetes/portforward/forwarder_manager.go 31.57% <33.33%> (ø)
pkg/skaffold/kubernetes/log.go 39.47% <87.50%> (+0.53%) ⬆️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 86.15% <100.00%> (+0.21%) ⬆️
pkg/skaffold/kubernetes/watcher.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/logger.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/portforwarder.go 100.00% <100.00%> (ø)

Fixes GoogleContainerTools#1753

Signed-off-by: David Gageot <david@gageot.net>
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 11b78e0 into GoogleContainerTools:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--tail In Deploy Mode Mixes Outputs
3 participants