Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message "Press ctrl c to exit" on forward manager start #4113

Merged
merged 4 commits into from May 10, 2020

Conversation

gsquared94
Copy link
Collaborator

Fixes: #3415

Description
Show message "Press ctrl c to exit" on forward manager start

User facing changes (remove if N/A)

image

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4113 into master will increase coverage by 0.31%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/build_deploy.go 56.12% <0.00%> (-1.49%) ⬇️
pkg/skaffold/deploy/labeller.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/skaffold/errors/errors.go 76.19% <0.00%> (-23.81%) ⬇️
cmd/skaffold/app/cmd/deploy.go 69.44% <0.00%> (-11.21%) ⬇️
...skaffold/kubernetes/debugging/container_manager.go 43.28% <0.00%> (-5.05%) ⬇️
cmd/skaffold/app/cmd/commands.go 95.12% <0.00%> (-4.88%) ⬇️
pkg/skaffold/deploy/kubectl/cli.go 90.90% <0.00%> (-3.83%) ⬇️
pkg/skaffold/runner/debugging.go 30.00% <0.00%> (-3.34%) ⬇️
pkg/skaffold/deploy/status_check.go 65.06% <0.00%> (-3.25%) ⬇️
pkg/skaffold/runner/dev.go 65.11% <0.00%> (-0.38%) ⬇️
... and 25 more

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just one little nit.

@briandealwis briandealwis added the kokoro:run runs the kokoro jobs on a PR label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 8, 2020
@dgageot dgageot merged commit c261d1c into GoogleContainerTools:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold run --port-forward behaves like it's freezing
6 participants