Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Only listen to pods for the current RunID" #4122

Merged
merged 1 commit into from May 7, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 6, 2020

This reverts commit a881930.

Fixes #4117
Reopen #1753

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4122 into master will increase coverage by 0.06%.
The diff coverage is 71.42%.

Impacted Files Coverage Δ
...skaffold/kubernetes/debugging/container_manager.go 48.33% <0.00%> (+5.04%) ⬆️
pkg/skaffold/runner/debugging.go 33.33% <ø> (+3.33%) ⬆️
...affold/kubernetes/portforward/forwarder_manager.go 31.57% <33.33%> (ø)
pkg/skaffold/kubernetes/log.go 38.93% <85.71%> (-0.54%) ⬇️
...g/skaffold/kubernetes/portforward/pod_forwarder.go 85.93% <100.00%> (-0.22%) ⬇️
pkg/skaffold/kubernetes/watcher.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/logger.go 100.00% <100.00%> (ø)
pkg/skaffold/runner/portforwarder.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 68.29% <0.00%> (+2.43%) ⬆️

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this now so we can release a hot fix. we can figure out the best way to solve this for helm later.

@nkubala nkubala added the kokoro:run runs the kokoro jobs on a PR label May 6, 2020
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label May 6, 2020
@dgageot dgageot merged commit fa4fb72 into GoogleContainerTools:master May 7, 2020
nkubala pushed a commit to nkubala/skaffold that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] regression: logs are not being tailed in 1.9.0
4 participants