Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to kaniko v0.20.0 #4128

Merged
merged 1 commit into from May 7, 2020
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 7, 2020

This is a follow up of #4125

Looks like something in the 0.21.0 Kaniko release broke GCB auth.
This fixes the CI

Signed-off-by: David Gageot david@gageot.net

Looks like something in the 0.21.0 Kaniko release broke GCB auth.
This fixes the CI

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #4128 into master will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 90.62% <ø> (ø)

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, in the interest of getting the CI to green. I'm not sure if pinning Kaniko is the right thing in the medium term — or we should be pinning lotsa others?

@dgageot dgageot merged commit 963a59f into GoogleContainerTools:master May 7, 2020
nkubala pushed a commit to nkubala/skaffold that referenced this pull request May 7, 2020
Looks like something in the 0.21.0 Kaniko release broke GCB auth.
This fixes the CI

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants