Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow error from kind at image loading to propagate #4196

Merged
merged 1 commit into from May 16, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented May 16, 2020

This came up during integration testing.

Previous output:

 loading images into kind nodes: unable to load image with kind "gcr.io/k8s-skaffold/skaffold-example:ad4adf2213c59a487ebf578f5f67c4a0ba030ac36ce16f4ac6d75f04a273e35f": exit status 1

This PR's output:

 loading images into kind nodes: unable to load image with kind "gcr.io/k8s-skaffold/skaffold-example:6838e8133d96ef77de6d3702179c597411c038cb99de06360a58cbdbac5721f8": running [kind load docker-image --name modified-context gcr.io/k8s-skaffold/skaffold-example:6838e8133d96ef77de6d3702179c597411c038cb99de06360a58cbdbac5721f8]
         - stdout: ""
         - stderr: "ERROR: no nodes found for cluster \"modified-context\"\n"
         - cause: exit status 1, 

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #4196 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
pkg/skaffold/runner/kind.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️

@balopat balopat merged commit 78b1b9f into GoogleContainerTools:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants