Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of per-command default values #4209

Merged
merged 1 commit into from May 18, 2020
Merged

Better handling of per-command default values #4209

merged 1 commit into from May 18, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented May 18, 2020

Common flags can now have a default value that's different based on the command.

Signed-off-by: David Gageot david@gageot.net

@codecov
Copy link

codecov bot commented May 18, 2020 •
edited

Codecov Report

Merging #4209 into master will increase coverage by 0.19%.
The diff coverage is 77.77%.

Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 69.53% <ø> (+4.28%) ⬆️
cmd/skaffold/app/cmd/flags.go 86.36% <77.77%> (-13.64%) ⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go 65.85% <0.00%> (-2.44%) ⬇️
pkg/skaffold/server/server.go 58.57% <0.00%> (ø)
cmd/skaffold/app/cmd/run.go 52.94% <0.00%> (+5.88%) ⬆️
pkg/skaffold/util/config.go 78.94% <0.00%> (+10.52%) ⬆️
pkg/skaffold/update/update.go 59.37% <0.00%> (+25.00%) ⬆️
cmd/skaffold/app/cmd/debug.go 100.00% <0.00%> (+50.00%) ⬆️
pkg/skaffold/deploy/transformations.go 100.00% <0.00%> (+100.00%) ⬆️

@dgageot dgageot marked this pull request as draft May 18, 2020 09:39
@dgageot dgageot force-pushed the special-default-values branch 2 times, most recently from e2bda9b to 62f5a73 Compare May 18, 2020 12:52
@dgageot
Apply per-command default values to flags
6b79607 
Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot assigned dgageot and unassigned dgageot May 18, 2020
@dgageot dgageot marked this pull request as ready for review May 18, 2020 19:22
@balopat balopat merged commit 0a33ef4 into GoogleContainerTools:master May 18, 2020
briandealwis
briandealwis reviewed May 19, 2020
View reviewed changes
cmd/skaffold/app/cmd/run_test.go

t.CheckDeepEqual(false, opts.Tail)
t.CheckDeepEqual(false, opts.Force)
t.CheckDeepEqual(false, opts.Force)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opts.EnableRPC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!. I'll fix that

cmd/skaffold/app/cmd/debug_test.go

t.CheckDeepEqual(true, opts.Tail)
t.CheckDeepEqual(false, opts.Force)
t.CheckDeepEqual(false, opts.Force)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opts.EnableRPC?

cmd/skaffold/app/cmd/dev_test.go

t.CheckDeepEqual(true, opts.Tail)
t.CheckDeepEqual(true, opts.Force)
t.CheckDeepEqual(true, opts.Force)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opts.EnableRPC?

@fmotrifork fmotrifork mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis left review comments

@balopat balopat balopat approved these changes

@nkubala nkubala Awaiting requested review from nkubala

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dgageot @briandealwis @balopat @googlebot