move field reported to changed #4222

tejal29 · 2020-05-19T08:54:31Z

Description
I am working on hooking up pod statuses into skaffold.
With pod statuses now coming in, we need a variable to track if a pod status which is part of deployment is changed to print out deployment and pod statuses together like this.

- deployment/leeroy-web is ready. [1/2 deployment(s) still pending]
 - deployment/leeroy-app: waiting for rollout to finish: 1 old replicas are pending termination...
    - pod/leeroy-app-85dfb77b44-md2dd: container leeroy-app is waiting to start: leeroy-app1 can't be pulled
 - deployment/leeroy-app: waiting for rollout to finish: 1 old replicas are pending termination...
    - pod/leeroy-app-85dfb77b44-wemde: container leeroy-app in error: Back-off pulling image "leeroy-app1"

Repurposing the previous reported to indicate if a deployment status was changed because a new pod came status was available or new pod came up.

codecov · 2020-05-19T09:04:13Z

Codecov Report

Merging #4222 into master will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
pkg/skaffold/deploy/resource/deployment.go	`93.33% <100.00%> (+0.35%)`	⬆️
pkg/skaffold/deploy/resource/status.go	`100.00% <100.00%> (ø)`
pkg/skaffold/runner/deploy.go	`38.33% <0.00%> (-22.20%)`	⬇️
pkg/skaffold/runner/intent.go	`79.31% <0.00%> (-20.69%)`	⬇️
pkg/skaffold/kubernetes/watcher.go	`87.50% <0.00%> (-12.50%)`	⬇️
...affold/kubernetes/portforward/kubectl_forwarder.go	`60.97% <0.00%> (-7.32%)`	⬇️
pkg/skaffold/server/server.go	`53.65% <0.00%> (-4.92%)`	⬇️
pkg/skaffold/runner/new.go	`64.51% <0.00%> (-4.84%)`	⬇️
pkg/skaffold/util/cmd.go	`47.61% <0.00%> (-4.77%)`	⬇️
...ffold/kubernetes/portforward/resource_forwarder.go	`84.31% <0.00%> (-3.45%)`	⬇️
... and 24 more

pkg/skaffold/deploy/resource/deployment.go

briandealwis · 2020-05-29T13:19:50Z

pkg/skaffold/deploy/resource/deployment.go

@@ -111,7 +114,7 @@ func (d *Deployment) IsStatusCheckComplete() bool {
 }

 func (d *Deployment) ReportSinceLastUpdated() string {
-	if d.status.reported {
+	if d.status.reported && !d.status.changed {


This doesn't seem right as .reported is only ever changed here and it's always set to true.

I think you just want to track the last-reported status and the current status, and compare them here.

@briandealwis This works correctly because, for every new status seen, we create a status with constructor newStatus.
The .reported set to false.
See deployment.go L57

briandealwis · 2020-05-29T13:22:27Z

pkg/skaffold/deploy/resource/deployment.go

-		}
+	if d.status.Equal(updated) {
+		d.status.changed = false
+		return


Is this return appropriate here? You still need to check the isErrAndNotRetryable(err) to possibly set done?

umm no. the status is already same as previous state. We don't need to perform any checks. The done status should have been set in the last iteration.

briandealwis · 2020-06-05T18:29:36Z

pkg/skaffold/deploy/resource/deployment.go

@@ -111,7 +114,7 @@ func (d *Deployment) IsStatusCheckComplete() bool {
 }

 func (d *Deployment) ReportSinceLastUpdated() string {
-	if d.status.reported {
+	if d.status.reported && !d.status.changed {


move filed reported to changed

eb5cbcb

tejal29 requested review from balopat, briandealwis, dgageot and nkubala as code owners May 19, 2020 08:54

googlebot added the cla: yes label May 19, 2020

pull-request-size bot added the size/S label May 19, 2020

tejal29 mentioned this pull request May 19, 2020

Initial prototype for pod health check hook up #4223

Merged

7 tasks

briandealwis changed the title ~~move filed reported to changed~~ move field reported to changed May 20, 2020

briandealwis reviewed May 20, 2020

View reviewed changes

pkg/skaffold/deploy/resource/deployment.go Show resolved Hide resolved

tejal29 requested a review from tstromberg as a code owner May 28, 2020 21:49

pull-request-size bot added size/M and removed size/S labels May 28, 2020

changed multiple times reported one

a745d28

tejal29 force-pushed the changeLastReported branch from c1a42fd to a745d28 Compare May 28, 2020 21:51

briandealwis reviewed May 29, 2020

View reviewed changes

briandealwis approved these changes Jun 5, 2020

View reviewed changes

tejal29 merged commit 08b086c into GoogleContainerTools:master Jun 5, 2020

fmotrifork mentioned this pull request Jun 12, 2020

skaffold 1.11.0 fishworks/fish-food#783

Merged

tejal29 deleted the changeLastReported branch April 15, 2021 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move field reported to changed #4222

move field reported to changed #4222

tejal29 commented May 19, 2020 •

edited

codecov bot commented May 19, 2020 •

edited

briandealwis May 29, 2020

tejal29 Jun 1, 2020 •

edited

briandealwis Jun 5, 2020

briandealwis May 29, 2020

tejal29 Jun 1, 2020 •

edited

briandealwis Jun 5, 2020

move field reported to changed #4222

move field reported to changed #4222

Conversation

tejal29 commented May 19, 2020 • edited

codecov bot commented May 19, 2020 • edited

Codecov Report

briandealwis May 29, 2020

Choose a reason for hiding this comment

tejal29 Jun 1, 2020 • edited

Choose a reason for hiding this comment

briandealwis Jun 5, 2020

Choose a reason for hiding this comment

briandealwis May 29, 2020

Choose a reason for hiding this comment

tejal29 Jun 1, 2020 • edited

Choose a reason for hiding this comment

briandealwis Jun 5, 2020

Choose a reason for hiding this comment

tejal29 commented May 19, 2020 •

edited

codecov bot commented May 19, 2020 •

edited

tejal29 Jun 1, 2020 •

edited

tejal29 Jun 1, 2020 •

edited