Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP Buildpacks builder image references to :v1 #4313

Merged
merged 1 commit into from Jun 11, 2020

Conversation

briandealwis
Copy link
Member

Description

GCP Buildpacks has changed to use a versioning scheme via an image tag to avoid breaking consumers from breaking changes. This PR changes all references to gcr.io/buildpacks/builder to add the new :v1 image tag. I updated the relevant pkg/skaffold/schema/ update tests too, though they don't actually matter.

User facing changes (remove if N/A)

  • all examples use :v1

@briandealwis briandealwis changed the title Update GCP Buildpacks builder image reference Update GCP Buildpacks builder image references Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #4313 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4313      +/-   ##
==========================================
+ Coverage   71.93%   71.96%   +0.03%     
==========================================
  Files         322      323       +1     
  Lines       12313    12370      +57     
==========================================
+ Hits         8857     8902      +45     
- Misses       2896     2904       +8     
- Partials      560      564       +4     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 60.97% <0.00%> (-2.44%) ⬇️
cmd/skaffold/app/cmd/cmd.go 67.64% <0.00%> (-1.89%) ⬇️
pkg/skaffold/config/util.go 71.26% <0.00%> (-0.35%) ⬇️
pkg/skaffold/initializer/init.go 37.20% <0.00%> (ø)
pkg/skaffold/schema/util/util.go 81.81% <0.00%> (ø)
cmd/skaffold/app/cmd/config/list.go 65.21% <0.00%> (ø)
pkg/skaffold/deploy/kubectl/visitor.go 95.83% <0.00%> (ø)
pkg/skaffold/schema/v2beta4/upgrade.go 100.00% <0.00%> (ø)
pkg/skaffold/yaml/yaml.go 81.25% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7731b62...3a2ee2f. Read the comment docs.

@briandealwis briandealwis changed the title Update GCP Buildpacks builder image references Update GCP Buildpacks builder image references to :v1 Jun 11, 2020
@briandealwis
Copy link
Member Author

fyi @lukasberger

@dgageot dgageot merged commit a3b2132 into GoogleContainerTools:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants