Fix propagation of buildpacks working directory #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandealwis
requested review from
balopat,
dgageot,
loosebazooka,
nkubala and
tejal29
as code owners
|
cc: @etanshaul @redborian |
Codecov Report
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
- Coverage 71.82% 71.81% -0.02%
==========================================
Files 324 324
Lines 12474 12476 +2
==========================================
Hits 8960 8960
- Misses 2947 2948 +1
- Partials 567 568 +1
Continue to review full report at Codecov.
|
tejal29
approved these changes
Jun 17, 2020
gsquared94
reviewed
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I backed out a critical commit to change the working directory in #4326 that was masked by a different change to the CNB tests.
More deeply:
debugworks by examining the container image run configuration (specifically the entrypoint + command, environment). CNB images use a launcher process that retrieves the actual command from configuration files in the image; this information is also available as annotations on the image. The CNB debug support wraps the normal debug transformation process, providing an image run configuration information that was rewritten from the CNB information. It also needs to unwrap some of the changes. One aspect that was missed here was to unwrap the reported working directory.