[buildpacks] debug detect direct processes with /bin/sh -c ...
#4345
Conversation
briandealwis
force-pushed
the
cnb-procfiles
branch
2 times, most recently
from
385274d
to
a6d4f4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4345 +/- ##
=======================================
Coverage 71.74% 71.75%
=======================================
Files 324 324
Lines 12511 12515 +4
=======================================
+ Hits 8976 8980 +4
Misses 2966 2966
Partials 569 569
Continue to review full report at Codecov.
|
| return append([]string{"--"}, transformed...) | ||
| // Detect and unwrap `/bin/sh -c ...`-style command lines; GCP Buildpacks turn Procfiles into `/bin/bash -c ...` | ||
| if (p.Command == "/bin/sh" || p.Command == "/bin/bash") && len(p.Args) >= 2 && p.Args[0] == "-c" { | ||
| p.Command = p.Args[1] |
There was a problem hiding this comment.
is the command is Command: "/bin/sh", Args: []string{"-c", "command arg1 arg2"} as in your test case, then
p.Command = strings.Split(p.Args[2], " ")[0] and
p.Args = strings.Split(p.Args[2], " ")[1:]
or is it the case at this point, p.Args is already a space separated array of all args?
There was a problem hiding this comment.
So p.Args[1] is the script provided to sh -c. p.Args[2:] are then mapped to arguments for that shell script. So it's very rarely done:
$ sh -c 'echo "0 - $0"; i=0; for arg in $*; do i=$(($i + 1)); echo "$i - $arg"; done' hi there how are you
0 - hi
1 - there
2 - how
3 - are
4 - youNote that strings.Split(..., " ") doesn't take into account quoted strings, etc.
There was a problem hiding this comment.
(It's entirely possible that they provide /bin/sh -x -c '...' but I'm fine with giving up and saying "🙅♂️ no debug for you".)
GCP Buildpacks turn Procfile processes into direct processes that invoke `/bin/bash` with arguments `-c procscript`. Although this seems odd, it's really a special case of the script-type process launch.
briandealwis
force-pushed
the
cnb-procfiles
branch
from
a6d4f4b
to
f5a251d
Compare
Description
GCP Buildpacks turn Procfile processes into direct processes that invoke
/bin/bashwith arguments-c procscript. Although this seems odd, it's really a special case of the script-type process launch.