Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Custom Builder command #4359

Merged
merged 1 commit into from Jun 19, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 19, 2020

Fixes #4340

Signed-off-by: David Gageot david@gageot.net

Fixes GoogleContainerTools#4340

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot requested a review from a team as a code owner June 19, 2020 17:32
@dgageot dgageot requested a review from tejal29 June 19, 2020 17:32
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #4359 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4359      +/-   ##
==========================================
- Coverage   71.74%   71.74%   -0.01%     
==========================================
  Files         324      324              
  Lines       12506    12507       +1     
==========================================
  Hits         8973     8973              
- Misses       2965     2966       +1     
  Partials      568      568              
Impacted Files Coverage Δ
pkg/skaffold/build/custom/script.go 52.08% <0.00%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5d7c3...320616c. Read the comment docs.

@dgageot
Copy link
Contributor Author

dgageot commented Jun 19, 2020

Let's ignore codecov

@dgageot dgageot merged commit a6033c8 into GoogleContainerTools:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom builder command-line is not shown
3 participants