Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a constant for pushing image and use that to parse error codes #4372

Merged
merged 1 commit into from Jun 23, 2020

Conversation

tejal29
Copy link
Member

@tejal29 tejal29 commented Jun 22, 2020

Fixes #4025

In this PR,

  • Create a constant to wrap error messages when Push fails.
  • Replace "errors.Wrap` to use this constant
    • when pushing using local docker api
    • when pushing via remote client
    • when pushing the to cache.

I think we cover all the places.

@tejal29 tejal29 requested a review from a team as a code owner June 22, 2020 23:13
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #4372 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4372   +/-   ##
=======================================
  Coverage   71.69%   71.69%           
=======================================
  Files         324      324           
  Lines       12547    12547           
=======================================
  Hits         8996     8996           
  Misses       2976     2976           
  Partials      575      575           
Impacted Files Coverage Δ
pkg/skaffold/build/cache/retrieve.go 69.31% <0.00%> (ø)
pkg/skaffold/docker/remote.go 12.96% <0.00%> (ø)
pkg/skaffold/errors/buildProblems.go 100.00% <ø> (ø)
pkg/skaffold/errors/err_map.go 100.00% <ø> (ø)
pkg/skaffold/docker/image.go 74.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa43689...ad073de. Read the comment docs.

@tejal29
Copy link
Member Author

tejal29 commented Jun 23, 2020

Intellij logs before:
intell-before

Intellij logs after.
Intellij-after

@tejal29 tejal29 merged commit 46badeb into GoogleContainerTools:master Jun 23, 2020
@tejal29 tejal29 deleted the fix_build_denied branch April 15, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add an error code for image repository access issue.
3 participants