Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3679
Description
On Windows OS,
kubectl portforward
command launches child processes that do not get cleaned up on the dev loop rerun. This way open ports keep getting locked up.This PR introduces
kubectl.Cmd
which embedsexec.Cmd
. TheStart
andRun
methods are overridden for Windows OS (using build tags) to wrap around a job object and the job object handle is closed on cancellation to ensure all processes get killed. For non windows OSes it behaves identical toexec.Cmd
.