Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skaffold init for java projects. #4379

Merged
merged 1 commit into from Jun 24, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jun 23, 2020

A pom.xml/build.gradle can be built with Jib and Buildpacks.

Fixes #4378

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot requested a review from a team as a code owner June 23, 2020 19:44
@dgageot dgageot requested a review from tejal29 June 23, 2020 19:44
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #4379 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
+ Coverage   71.73%   71.75%   +0.01%     
==========================================
  Files         325      325              
  Lines       12572    12573       +1     
==========================================
+ Hits         9019     9022       +3     
+ Misses       2977     2976       -1     
+ Partials      576      575       -1     
Impacted Files Coverage Δ
pkg/skaffold/initializer/analyze/builder.go 100.00% <100.00%> (ø)
pkg/skaffold/kubernetes/util.go 93.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79f260...87d2b0b. Read the comment docs.

A pom.xml/build.gradle can be built with Jib and Buildpacks.

Fixes GoogleContainerTools#4378

Signed-off-by: David Gageot <david@gageot.net>
@briandealwis briandealwis merged commit 05c8919 into GoogleContainerTools:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold init --analyze builder detection for Java heuristic needs improvement
3 participants