Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and error message about pullSecretPath #4381

Merged
merged 6 commits into from Jun 24, 2020
Merged

Fix docs and error message about pullSecretPath #4381

merged 6 commits into from Jun 24, 2020

Conversation

chanseokoh
Copy link
Member

The property was renamed to pullSecretPath in #4147 and now serves as a dual-purpose property:

  • Sometimes used to specify a path to a local secret file.
  • Other times only used for the mount path of a secret file inside a Kaniko pod.

@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #4381 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4381      +/-   ##
==========================================
- Coverage   71.78%   71.77%   -0.02%     
==========================================
  Files         325      325              
  Lines       12594    12594              
==========================================
- Hits         9041     9039       -2     
- Misses       2978     2979       +1     
- Partials      575      576       +1     
Impacted Files Coverage Δ
pkg/skaffold/schema/defaults/defaults.go 90.72% <0.00%> (ø)
pkg/skaffold/build/cluster/secret.go 41.53% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 60.97% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f14d11...e877450. Read the comment docs.

@chanseokoh chanseokoh merged commit f05cbbf into GoogleContainerTools:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants