Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lenient parsing of minikube docker-env #4422

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 1, 2020

Signed-off-by: David Gageot david@gageot.net

@dgageot dgageot requested a review from a team as a code owner July 1, 2020 09:39
@dgageot dgageot requested a review from tejal29 July 1, 2020 09:39
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #4422 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
+ Coverage   71.68%   71.70%   +0.01%     
==========================================
  Files         329      329              
  Lines       12804    12804              
==========================================
+ Hits         9179     9181       +2     
+ Misses       3043     3042       -1     
+ Partials      582      581       -1     
Impacted Files Coverage Δ
pkg/skaffold/docker/client.go 75.23% <100.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 63.41% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0a427...f355430. Read the comment docs.

Signed-off-by: David Gageot <david@gageot.net>
@tejal29 tejal29 merged commit c289f4c into GoogleContainerTools:master Jul 1, 2020
@briandealwis briandealwis added this to the v1.12.1 milestone Jul 14, 2020
@briandealwis briandealwis mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants