Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug supports /bin/sh -c and /bin/bash -c command-lines #4442

Merged
merged 2 commits into from
Jul 4, 2020

Conversation

briandealwis
Copy link
Member

Fixes: #4397

Description

The debug support now attempts to unwrap (and rewraps) container command-lines that use /bin/sh -c-style command-lines.

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #4442 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4442      +/-   ##
==========================================
+ Coverage   72.14%   72.24%   +0.09%     
==========================================
  Files         329      329              
  Lines       12820    12850      +30     
==========================================
+ Hits         9249     9283      +34     
+ Misses       2978     2975       -3     
+ Partials      593      592       -1     
Impacted Files Coverage Δ
pkg/skaffold/debug/cnb.go 93.10% <100.00%> (ø)
pkg/skaffold/debug/transform.go 91.24% <100.00%> (+2.47%) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 63.41% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ee88f...8dfca40. Read the comment docs.

@briandealwis briandealwis merged commit 6b8b50a into GoogleContainerTools:master Jul 4, 2020
@briandealwis briandealwis deleted the sh-c branch July 4, 2020 00:48
@briandealwis briandealwis added this to the v1.12.1 milestone Jul 13, 2020
@briandealwis briandealwis mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug detect direct processes with /bin/sh -c ...
3 participants