Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable update check and survey prompt in non-interactive mode #4508

Merged
merged 2 commits into from Jul 21, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Jul 21, 2020

Fixes #4506

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #4508 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4508      +/-   ##
==========================================
- Coverage   72.36%   72.35%   -0.01%     
==========================================
  Files         333      333              
  Lines       12956    12959       +3     
==========================================
+ Hits         9376     9377       +1     
- Misses       2982     2984       +2     
  Partials      598      598              
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 66.17% <33.33%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6706e1c...759d0fc. Read the comment docs.

@dgageot
Copy link
Contributor Author

dgageot commented Jul 21, 2020

Let me try to add a test

@dgageot
Copy link
Contributor Author

dgageot commented Jul 21, 2020

In fact, it's a part of the code that's hard to test and the test wouldn't really add much value. Let's merge like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide survey link for embedded use cases
3 participants