Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable watch trigger only when at least one of autoBuild, autoSync or autoDeploy is enabled #4676

Merged
merged 2 commits into from Aug 17, 2020

Conversation

gsquared94
Copy link
Collaborator

Fixes #4653, #4501

  • Shows "Watching for changes" output message along with file change debug level logs only when at least one of auto build, sync or deploy are enabled which is usually the case for dev and run.
  • Shows "Not watching for changes" output message when all of auto build, sync and deploy are turned off which is the case for debug

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #4676 into master will decrease coverage by 0.02%.
The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4676      +/-   ##
==========================================
- Coverage   73.21%   73.18%   -0.03%     
==========================================
  Files         339      339              
  Lines       13323    13346      +23     
==========================================
+ Hits         9754     9767      +13     
- Misses       2958     2968      +10     
  Partials      611      611              
Impacted Files Coverage Δ
pkg/skaffold/runner/intent.go 74.19% <0.00%> (-5.12%) ⬇️
pkg/skaffold/trigger/triggers.go 37.93% <76.92%> (+5.97%) ⬆️
pkg/skaffold/runner/new.go 67.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 283e9c4...5b094fb. Read the comment docs.

Copy link
Contributor

@MarlonGamez MarlonGamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me 👍🏽 I had only a small nit related to comments

pkg/skaffold/trigger/triggers.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running skaffold in debug mode shows watching for changes
3 participants