Return deployment status code when status check can't retrieve pods from cluster #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4683 +/- ##
==========================================
- Coverage 73.21% 73.18% -0.03%
==========================================
Files 339 339
Lines 13323 13348 +25
==========================================
+ Hits 9754 9769 +15
- Misses 2958 2968 +10
Partials 611 611
Continue to review full report at Codecov.
|
tejal29
approved these changes
Aug 18, 2020
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Aug 20, 2020
…k-no-pods Return deployment status code when status check can't retrieve pods from cluster
nkubala
pushed a commit
to nkubala/skaffold
that referenced
this pull request
Aug 20, 2020
…k-no-pods Return deployment status code when status check can't retrieve pods from cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4672
this fixes an issue with the status checker where it mistakenly thought everything was fine when it detected a failure, but found no failures with any associated pods in a deployment. this happened when skaffold was unable to connect to the cluster, resulting in zero pods being retrieved for a deployment. skaffold will now use the status code for the deployment itself when this scenario happens, rather than returning
OK.